RFR and sponsor: 8248231: deserializeLambda created with wrong encoding if platform encoding not UTF-8

[Joe Darcy]

The two-reviewer rule used by HotSpot is not used in other areas of the 
JDK, including javac.

-Joe

On 7/7/2020 8:22 AM, Andrew Leonard wrote:
> Thank you Vincente,
> Would you be able to sponsor pushing this please?
>
> I also need a 2nd review please, anyone?
>
> Thanks,
> Andrew
>
> Andrew Leonard
> Java Runtimes Development
> IBM Hursley
> IBM United Kingdom Ltd
> internet email: andrew_m_leonard at uk.ibm.com
>
>
>
>
> From: Vicente Romero <vicente.romero at oracle.com>
> To: Andrew Leonard <andrew_m_leonard at uk.ibm.com>, 
> compiler-dev at openjdk.java.net
> Date: 07/07/2020 15:34
> Subject: [EXTERNAL] Re: RFR and sponsor: 8248231: deserializeLambda 
> created with wrong encoding if platform encoding not UTF-8
> ------------------------------------------------------------------------
>
>
>
> looks good to me,
> Vicente
>
> On 7/6/20 7:01 AM, Andrew Leonard wrote:
> Any sponsors please?
>
> Many thanks
> Andrew
>
> Andrew Leonard
> Java Runtimes Development
> IBM Hursley
> IBM United Kingdom Ltd
> internet email: _andrew_m_leonard at uk.ibm.com_ 
> <mailto:andrew_m_leonard at uk.ibm.com>
>
>
>
>
> From: Andrew Leonard/UK/IBM
> To: _compiler-dev at openjdk.java.net_ <mailto:compiler-dev at openjdk.java.net>
> Date: 26/06/2020 11:40
> Subject: RFR and sponsor: 8248231: deserializeLambda created with 
> wrong encoding if platform encoding not UTF-8
> ------------------------------------------------------------------------
>
>
> Hi,
> Please can I request a sponsor and review for the fix to bug 
> JDK-8248231? (_https://bugs.openjdk.java.net/browse/JDK-8248231_)
> webrev for review: 
> _http://cr.openjdk.java.net/~aleonard/8248231/webrev.00/_
>
> The problem with incorrect encoding of deserializeLambda was 
> discovered by the openj9 VM team on a platform where the default 
> encoding is not UTF-8 (eg.EBCDIC platforms), which eluded to the 
> problem that the deserializeLambda was not been encoded correctly when 
> the lambda char did not map to an ASCII compatible range. The fix 
> testcase replicates the problem by using a suitable UTF-8 char that 
> does not map.
>
> Many thanks
> Andrew
>
> Andrew Leonard
> Java Runtimes Development
> IBM Hursley
> IBM United Kingdom Ltd
> internet email: _andrew_m_leonard at uk.ibm.com_ 
> <mailto:andrew_m_leonard at uk.ibm.com>
>
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with 
> number 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
>
>
>
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with 
> number 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 
> 3AU
>
>
>
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with 
> number 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20200707/fbc52071/attachment-0001.htm>