JDK 16 RFR of JDK-8249632: remove no-arg constructor from ToolProvider

[Joe Darcy]

*sigh* Yes, you're right -- I'll redo the fix making the constructor 
private. I'll have to try to get that -Xlint warning about default 
constructors into javac one of these releases!

-Joe

On 7/16/2020 7:52 PM, Jonathan Gibbons wrote:
> I'm surprised you're removing it like that: won't it just come back as 
> a default constructor?
>
> Don't you just want to make it private to make it disappear from the 
> public API?
>
> -- Jon
>
> On 7/16/20 7:07 PM, Joe Darcy wrote:
>> Hello,
>>
>> Please review the removal of a deprecated-for-removal constructor:
>>
>>     JDK-8249632: remove no-arg constructor from ToolProvider
>>     webrev: http://cr.openjdk.java.net/~darcy/8249632.0/
>>     CSR: https://bugs.openjdk.java.net/browse/JDK-8249644
>>
>> Patch below; thanks,
>>
>> -Joe
>>
>> --- old/src/java.compiler/share/classes/javax/tools/ToolProvider.java 
>> 2020-07-16 18:59:58.685000000 -0700
>> +++ new/src/java.compiler/share/classes/javax/tools/ToolProvider.java 
>> 2020-07-16 18:59:58.025000000 -0700
>> @@ -45,12 +45,6 @@
>>      private static final String systemJavaCompilerName   = 
>> "com.sun.tools.javac.api.JavacTool";
>>
>>      /**
>> -     * Do not call.
>> -     */
>> -    @Deprecated(forRemoval=true, since="14")
>> -    public ToolProvider() {}
>> -
>> -    /**
>>       * Returns the Java programming language compiler provided
>>       * with this platform.
>>       * <p>The file manager returned by calling
>>