JDK 16 RFR of JDK-8249632: remove no-arg constructor from ToolProvider

[Jonathan Gibbons]

+1

On 7/17/20 10:31 AM, Joe Darcy wrote:
> Update
>
>     CSR: https://bugs.openjdk.java.net/browse/JDK-8249644
>     webrev: http://cr.openjdk.java.net/~darcy/8249632.1/
>
> and patch below. Build and langtools regression test still pass.
>
> Thanks,
>
> -Joe
>
> --- old/src/java.compiler/share/classes/javax/tools/ToolProvider.java 
> 2020-07-17 10:26:50.446004000 -0700
> +++ new/src/java.compiler/share/classes/javax/tools/ToolProvider.java 
> 2020-07-17 10:26:49.794004000 -0700
> @@ -44,11 +44,7 @@
>      private static final String systemJavaCompilerModule = 
> "jdk.compiler";
>      private static final String systemJavaCompilerName   = 
> "com.sun.tools.javac.api.JavacTool";
>
> -    /**
> -     * Do not call.
> -     */
> -    @Deprecated(forRemoval=true, since="14")
> -    public ToolProvider() {}
> +    private ToolProvider() {}
>
>      /**
>       * Returns the Java programming language compiler provided
>
>
> On 7/16/2020 9:52 PM, Joe Darcy wrote:
>> *sigh* Yes, you're right -- I'll redo the fix making the constructor 
>> private. I'll have to try to get that -Xlint warning about default 
>> constructors into javac one of these releases!
>>
>> -Joe
>>
>> On 7/16/2020 7:52 PM, Jonathan Gibbons wrote:
>>> I'm surprised you're removing it like that: won't it just come back 
>>> as a default constructor?
>>>
>>> Don't you just want to make it private to make it disappear from the 
>>> public API?
>>>
>>> -- Jon
>>>
>>> On 7/16/20 7:07 PM, Joe Darcy wrote:
>>>> Hello,
>>>>
>>>> Please review the removal of a deprecated-for-removal constructor:
>>>>
>>>>     JDK-8249632: remove no-arg constructor from ToolProvider
>>>>     webrev: http://cr.openjdk.java.net/~darcy/8249632.0/
>>>>     CSR: https://bugs.openjdk.java.net/browse/JDK-8249644
>>>>
>>>> Patch below; thanks,
>>>>
>>>> -Joe
>>>>
>>>> --- 
>>>> old/src/java.compiler/share/classes/javax/tools/ToolProvider.java 
>>>> 2020-07-16 18:59:58.685000000 -0700
>>>> +++ 
>>>> new/src/java.compiler/share/classes/javax/tools/ToolProvider.java 
>>>> 2020-07-16 18:59:58.025000000 -0700
>>>> @@ -45,12 +45,6 @@
>>>>      private static final String systemJavaCompilerName   = 
>>>> "com.sun.tools.javac.api.JavacTool";
>>>>
>>>>      /**
>>>> -     * Do not call.
>>>> -     */
>>>> -    @Deprecated(forRemoval=true, since="14")
>>>> -    public ToolProvider() {}
>>>> -
>>>> -    /**
>>>>       * Returns the Java programming language compiler provided
>>>>       * with this platform.
>>>>       * <p>The file manager returned by calling
>>>>