RFR: 8236108 tools/javac/lambda/LambdaParserTest.java timed out

Vicente Romero vicente.romero at oracle.com
Mon Jun 8 20:34:33 UTC 2020


Hi Adam,

webrev.01 looks good to me,

Thanks,
Vicente

On 6/2/20 9:41 AM, Adam Sotona wrote:
> Hi,
> I would like to ask for review of LambdaParserTest.java timed out fix.
> This particular test is very complex and intensive.
> It includes 573696 test actions, each parsing a source fragment.
> As this single test takes on my powerful machine approx. 1 minute and the default timeout is 2 minutes, so I can imagine situations where it timeouts.
>
> Target machine scale factor was 4, so the default timeout was 480s, however the test elapsed time was 523s.
>
> Proposed patch extends the timeout by 50% to 180s, so multiplied by the machine-specific timeout scale factor it will give enough time to finish successfully.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8236108
> webrev: http://cr.openjdk.java.net/~asotona/8236108/webrev.00/
>
> The test is a part of Tier 4 and it is passing for me even without the extended timeout, so I cannot practically verify the patch effectivity unless it fails.
>
> Thanks,
> Adam



More information about the compiler-dev mailing list