RFR: JDK-8235339: test TargetAnnoCombo.java is failing after new target RECORD_COMPONENT was added

Vicente Romero vicente.romero at oracle.com
Sat Mar 14 20:49:31 UTC 2020


thanks for the review,
Vicente

On 3/14/20 12:57 PM, Joe Darcy wrote:
> Looks fine; cheers,
>
> -Joe
>
> On 3/13/2020 7:55 PM, Vicente Romero wrote:
>> Hi,
>>
>> Please review the fix for [1] at [2]. Records added a new annotation 
>> target: RECORD_COMPONENT. This combo test is generating several 
>> combinations of tests with repeated annotations. When some 
>> combinations were adding the new target, then they were failing as 
>> the incantation to use preview features was not being used. I also 
>> changed the method that return the default set of annotation targets 
>> to don't return RECORD_COMPONENT if records are not allowed.
>>
>> Thanks,
>> Vicente
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8235339
>> [2] http://cr.openjdk.java.net/~vromero/8235339/webrev.00/



More information about the compiler-dev mailing list