RFR: 8238735 NPE compiling lambda expression within conditional expression

[Maurizio Cimadamore]

I'm not sure about the fix... if there's a big lambda body with lots of 
errors inside which are independent from the target, the recovery step 
ensures that we report all such issues (which is useful when we are 
running e.g. inside an IDE). Ideally I'd like javac not to worry about 
recovery at all - but recovery was added for a reason; is that goal now 
less important?

 From the changes in the tests it is evident that with the patch some 
useful errors are now omitted.

Maurizio

On 18/05/2020 16:47, Adam Sotona wrote:
> Hi,
> I would like to ask for review of the patch fixing NPE while compiling lambda expression within conditional expression.
> The fix removes obsolete recovery cycle in com.sun.tools.javac.comp.Attr.visitLambda method when Types.FunctionDescriptorLookupError happens and it adds new test.
>
> JBS:  https://bugs.openjdk.java.net/browse/JDK-8238735
> webrev: http://cr.openjdk.java.net/~asotona/8238735/webrev.00/
>
> Mach 5 build with the patch passes all Tier1, Tier2 and Tier3 tests.
>
>
> Thank you,
> Adam