RFR: 8244573 java.lang.ArrayIndexOutOfBoundsException thrown for malformed class file

Adam Sotona adam.sotona at oracle.com
Tue May 26 05:36:17 UTC 2020


Hi Vicente,
thanks for the review, may I ask you to integrate the changeset, here is the changeset version of the webrev:
http://cr.openjdk.java.net/~asotona/8244573/webrev.02/

Thank you,
Adam

> On 26 May 2020, at 06:20, Vicente Romero <vicente.romero at oracle.com> wrote:
> 
> looks good,
> Vicente
> 
> On 5/18/20 5:28 AM, Adam Sotona wrote:
>> I've also added corresponding test using jcod-generated Malformed.class (thanks Vicente for your suggestion):
>> 
>> webrev: http://cr.openjdk.java.net/~asotona/8244573/webrev.01/ <http://cr.openjdk.java.net/~asotona/8244573/webrev.01/>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8244573 <https://bugs.openjdk.java.net/browse/JDK-8244573>
>> 
>>  
>> Thanks for the review,
>> Adam
>> 
>> 
>>> On 15 May 2020, at 16:36, Jonathan Gibbons <jonathan.gibbons at oracle.com <mailto:jonathan.gibbons at oracle.com>> wrote:
>>> 
>>> +1
>>> 
>>> -- Jon
>>> 
>>> On 5/15/20 6:05 AM, Adam Sotona wrote:
>>>> Hi,
>>>> I would like to ask for review of the patch fixing javap java.lang.ArrayIndexOutOfBoundsException in com.sun.tools.classfile.Code_attribute.getInstructions() for methods with no instructions.
>>>> 
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8244573 <https://bugs.openjdk.java.net/browse/JDK-8244573>
>>>> webrev: http://cr.openjdk.java.net/~asotona/8244573/webrev.00/ <http://cr.openjdk.java.net/~asotona/8244573/webrev.00/>
>>>> 
>>>> Mach 5 build with the patch passes all Tier1, Tier2 and Tier3 tests.
>>>> 
>>>> Thank you,
>>>> Adam
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20200526/66cefd05/attachment.htm>


More information about the compiler-dev mailing list