RFR: 8241312 missing code coverage for records

[Vicente Romero]

sure,

Vicente

On 5/26/20 12:58 AM, Adam Sotona wrote:
> Hi Vicente,
> thanks for the review, I've fixed the formatting of ApplicableAnnotationsOnRecords and created changeset version of the webrev here: http://cr.openjdk.java.net/~asotona/8241312/webrev.01/
>
> May I ask you for integration of the changeset?
>
> Thank you,
> Adam
>
>> On 25 May 2020, at 20:39, Vicente Romero <vicente.romero at oracle.com> wrote:
>>
>> Hi Adam,
>>
>> Thanks for fixing this, indentation looks odd at ApplicableAnnotationsOnRecords.java but apart from that it looks good,
>>
>> Vicente
>>
>>
>> On 5/21/20 9:45 AM, Adam Sotona wrote:
>>> Hi,
>>> I would like to ask for review of the patch adding new tests to improve test coverage for records.
>>> The patch adds:
>>>   - test for com.sun.tools.sjavac.comp.PubAPIs and com.sun.tools.sjavac.comp.PubapiVisitor
>>>   - test for com.sun.tools.javac.comp.Check::validateAnnotation, com.sun.tools.javac.code.SymbolMetadata::removeDeclarationMetadata and ::removeFromCompoundList
>>>   - test for javax.lang.model.util.ElementFilter::recordComponentsIn
>>>
>>> The patch however does not resolve comment about potentially dead code fragment of Lower::visitRecordDefalso described in JDK-8241312 . I was not able to reach that code by tests, however I'm unable to confirm that it is a dead code.
>>>
>>> JBS:  https://bugs.openjdk.java.net/browse/JDK-8241312
>>> webrev: http://cr.openjdk.java.net/~asotona/8241312/webrev.00/
>>>
>>> Mach 5 build with the patch passes all Tier1, Tier2 and Tier3 tests.
>>>
>>>
>>> Thank you,
>>> Adam