RFR: JDK-8241519: javac crashes with wrong module-info.class in module path

Jonathan Gibbons jonathan.gibbons at oracle.com
Thu May 28 17:15:58 UTC 2020


Looks good to me.

-- Jon

On 5/15/20 7:53 AM, Jan Lahoda wrote:
> Hi,
>
> When javac loads module-info.class, that is broken, and hence a 
> CompletionFailure (or BadClassFile) is thrown, the corresponding 
> ModuleSymbol is not marked as erroneous, and is not fully completed, 
> which may lead to follow on exceptions.
>
> The proposal is to mark the ModuleSymbol as erroneous, and do basic 
> initialization of it, when CompletionFailure is thrown while loading 
> the module-info.class.
>
> Proposed webrev:
> http://cr.openjdk.java.net/~jlahoda/8241519/webrev.00/
>
> JBS:
> https://bugs.openjdk.java.net/browse/JDK-8241519
>
> How does this look?
>
> Thanks,
>     Jan


More information about the compiler-dev mailing list