RFR: 8229862: NPE in jdk.compiler/com.sun.tools.javac.jvm.Code.emitop0(Code.java:570)
Jan Lahoda
jlahoda at openjdk.java.net
Mon Nov 16 10:38:03 UTC 2020
Based on Bernard's code from:
http://mail.openjdk.java.net/pipermail/compiler-dev/2020-October/015225.html
Capturing anonymous classes inside lambdas may fail to compile, because:
-the captured variables are not detected correctly, because `LambdaToMethod...captureLocalClassDefs` needs to find the AST node for the given `ClassSymbol`, but it has not yet been added into the `localClassDefs`. The proposed solution is to re-order the tasks done for JCNewClass, and call the super implementation sooner. This will enter the `ClassSymbol` and corresponding AST node into `localClassDefs` before the capture variables detection.
-inside the anonymous class definition, some references to the captured variables are replaced using a map that maps captured variables for lambdas (`lambdaTranslationMap`) - but inside the anonymous class, there the captured variables should be mapped using the anonymous class' map/proxies (to fields). The proposed solution is to clear `lambdaTranslationMap` before processing the anonymous class body.
-------------
Commit messages:
- 8229862: NPE in jdk.compiler/com.sun.tools.javac.jvm.Code.emitop0(Code.java:570)
Changes: https://git.openjdk.java.net/jdk/pull/1221/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1221&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8229862
Stats: 64 lines in 3 files changed: 62 ins; 1 del; 1 mod
Patch: https://git.openjdk.java.net/jdk/pull/1221.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/1221/head:pull/1221
PR: https://git.openjdk.java.net/jdk/pull/1221
More information about the compiler-dev
mailing list