RFR: 8256308: Send arguments to javac server in a config file [v6]

Magnus Ihse Bursie ihse at openjdk.java.net
Tue Nov 24 11:17:05 UTC 2020


On Tue, 24 Nov 2020 09:52:34 GMT, Joel Borggrén-Franck <jfranck at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix whitespace issues
>
> src/jdk.compiler/share/classes/com/sun/tools/sjavac/Util.java line 96:
> 
>> 94: 
>> 95:     public static String extractStringOptionLine(String opName, String s, String deflt) {
>> 96:         return extractStringOptionWithDelimiter(opName, s, deflt, '\n').strip();
> 
> Is '\n' going to be problematic due to differences in line endings on various platforms?

The JDK project is limited to unix-style line endings only. No other styles are supported, and any attempt to use such will break the build (often early on).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1195


More information about the compiler-dev mailing list