RFR: 8240658: Code completion not working for lambdas in method invocations that require type inference

[Advanced Static Source Code Analysis]

On Mon, 7 Sep 2020 11:28:45 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> When a method invocation requires type inference, and the user is in the process of typing of a (block) lambda that is
> a parameter to the method invocation, javac may not, in some cases, perform the type inference, which then may lead to
> non working code completion in JShell (and possibly other tools).  For example (in JShell):
> Arrays.stream(new Integer[]{1}).forEach(v -> { System.err.println(v.
> 
> and press <tab> - this leads to no proposals currently, as the type of "v" is not inferred.
> 
> The idea of the proposed patch is to improve the recovery in cases significant for cases where the text is being typed,
> and allow type inference in these cases. The type of "v" is then inferred, and the code completion works.

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/AttrRecover.java line 130:

> 128:                                                 lambda.body = new TreeTranslator() {
> 129:                                                     @SuppressWarnings("unchecked")
> 130:                                                     public <T extends JCTree> T translate(T t) {

Jackpot:
warning: Add @Override Annotation

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/AttrRecover.java line 82:

> 80:
> 81:     protected AttrRecover(Context context) {
> 82:         context.put(attrRepairKey, this);

Jackpot:
warning: Leaking this in constructor

-------------

PR: https://git.openjdk.java.net/jdk/pull/50