RFR: 8250217: com.sun.tools.javac.api.JavacTaskImpl swallows compiler exceptions potentially producing false positive test results

[Vicente Romero]

On Wed, 9 Sep 2020 12:07:59 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> 8250217: com.sun.tools.javac.api.JavacTaskImpl swallows compiler exceptions potentially producing false positive test
>> results
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java line 110:
> 
>> 108:                 return result.fst;
>> 109:             } else {
>> 110:                 return (result.snd instanceof FatalError) ? Main.Result.SYSERR : Main.Result.ABNORMAL;
> 
> It would be nicer if we didn't have to use an instanceof here, although I see it is somewhat difficult, so does not
> seem necessary.

right there are not many options

-------------

PR: https://git.openjdk.java.net/jdk/pull/88