RFR: 8240658: Code completion not working for lambdas in method invocations that require type inference [v3]

Jan Lahoda jlahoda at openjdk.java.net
Fri Sep 11 13:56:59 UTC 2020


On Thu, 10 Sep 2020 18:11:24 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Note this is a case where the invoked method is not a varargs method, and there are too many actual parameters. But it
>> is true the varags handling could be improved, which I tried to do in a recent patch (32845dd).
>
> I like the patch. I think it is great. My only comment would be about test: TestGetTypeMirrorReference.java which does
> a golden file like comparison but I understand that there are not many options. I would suggest though to place this
> test along with file: TestGetTypeMirrorReferenceData.java in a separate folder and add some doc to the test so that it
> would be easier to modify it in the future

Thanks!

I've tried to improve the text (moved to a separate directory, added comment) in 988f85b.

-------------

PR: https://git.openjdk.java.net/jdk/pull/50


More information about the compiler-dev mailing list