RFR: 8236842: Surprising 'multiple elements' behaviour from getTypeElement when cross-compiling with --release [v2]
Jan Lahoda
jlahoda at openjdk.java.net
Thu Sep 17 18:02:05 UTC 2020
On Wed, 16 Sep 2020 19:37:16 GMT, Vicente Romero <vromero at openjdk.org> wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Reflecting review comments - improving javadoc, avoid repeated search of modules that have already been searched.
>
> I have also made some small edits to the CSR and added myself as reviewer
@vicente-romero-oracle thanks for the comments! I've updated the patch and CSR based on the comments.
> src/jdk.compiler/share/classes/com/sun/tools/javac/model/JavacElements.java line 237:
>
>> 235: return Optional.empty();
>> 236: } else {
>> 237: //not found, try another option
>
> probably this else {} can be removed right?
It could be removed, but I added it intentionally to make it clear the "else" option has been considered, and is
intentional. I can remove it, if you strongly prefer, though.
-------------
PR: https://git.openjdk.java.net/jdk/pull/200
More information about the compiler-dev
mailing list