RFR: 8241151: Incorrect lint warning for no definition of serialVersionUID in a record

Jonathan Gibbons jjg at openjdk.java.net
Mon Sep 28 19:54:24 UTC 2020


On Fri, 25 Sep 2020 17:45:10 GMT, Vicente Romero <vromero at openjdk.org> wrote:

> Co-authored-by: Bernard Blaser <bsrbnd at gmail.com>
> Co-authored-by: Vicente Romero <vicente.romero at oracle.com>

You should add a bug number to the test.

test/langtools/tools/javac/records/RecordCompilationTests.java line 151:

> 149:
> 150:     public RecordCompilationTests() {
> 151:         useAP = System.getProperty("useAP") == null ? false : System.getProperty("useAP").equals("true");

I know this is unrelated to your change, but this line could be improved with

    useAP = System.getProperty("useAP", "false").equals("true")

-------------

Changes requested by jjg (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/363


More information about the compiler-dev mailing list