RFR: 8246774: implementing Record Classes as a standard feature in Java [v3]

Chris Hegarty chegar at openjdk.java.net
Wed Sep 30 08:56:37 UTC 2020

On Wed, 23 Sep 2020 03:34:29 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Co-authored-by: Vicente Romero <vicente.romero at oracle.com>
>> Co-authored-by: Harold Seigel <harold.seigel at oracle.com>
>> Co-authored-by: Jonathan Gibbons <jonathan.gibbons at oracle.com>
>> Co-authored-by: Brian Goetz <brian.goetz at oracle.com>
>> Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore at oracle.com>
>> Co-authored-by: Joe Darcy <joe.darcy at oracle.com>
>> Co-authored-by: Chris Hegarty <chris.hegarty at oracle.com>
>> Co-authored-by: Jan Lahoda <jan.lahoda at oracle.com>
> Vicente Romero has updated the pull request incrementally with three additional commits since the last revision:
>  - Merge pull request #1 from ChrisHegarty/record-serial-tests
>    Remove preview args from JDK tests
>  - Remove preview args from ObjectMethodsTest
>  - Remove preview args from record serialization tests

Marked as reviewed by chegar (Reviewer).

test/langtools/tools/javac/records/LocalStaticDeclarations.java line 33:

> 31:  *          jdk.compiler/com.sun.tools.javac.util
> 32:  * @build combo.ComboTestHelper
> 33:  * @compile LocalStaticDeclarations.java

This, and other, explicit at compile tags could be elided, no? The test source file will be implicitly compiled by the
at run tag. I believe that the explicit at compile tag was added original so that the enable preview and source version
options could be passed to javac - neither of which are needed any more.


PR: https://git.openjdk.java.net/jdk/pull/290

More information about the compiler-dev mailing list