RFR: 8253455: Record Classes javax.lang.model changes [v5]
Joe Darcy
joe.darcy at oracle.com
Wed Sep 30 21:29:49 UTC 2020
On 9/30/2020 2:00 AM, Chris Hegarty wrote:
> On Tue, 29 Sep 2020 21:37:58 GMT, Vicente Romero <vromero at openjdk.org> wrote:
>
>>> Please review the fix for [JDK-8253455](https://bugs.openjdk.java.net/browse/JDK-8253455) which is part of the effort
>>> to make records a final feature of the Java Language. The rest of the code has been published in
>>> [PR#290](https://github.com/openjdk/jdk/pull/290) Thanks,
>>> Vicente
>> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
>>
>> adding a comment to PreviewFeature.Feature
> src/java.compiler/share/classes/javax/lang/model/element/ElementKind.java line 114:
>
>> 112: /**
>> 113: * A record type.
>> 114: * @since 14
> The `@since` tags will all need to be updated to `16`, right?
While I acknowledge that is what the current version of the JEP directs
to happen in this situation, the API elements in question really are
present in 14 and 15 so I don't think saying they are "since 16" is
necessarily clearer.
-Joe
More information about the compiler-dev
mailing list