RFR: 8261625: Add `Elements.isAutomaticModule(ModuleElement)` [v3]

Joe Darcy darcy at openjdk.java.net
Thu Apr 8 17:26:33 UTC 2021

> Addition of a small convenience method, with a default implementation, to Elements.
> Most of the change is testing infrastructure. The negative cases, such as named modules, are tested in the style of other annotation processing tests for Elements utilities.
> An automatic module comes from a jar file, so an API reading from a jar file is needed. To avoid piping in the awkward plumbing needed to do that directly in the annotation processing tests, I updated an existing automatic modules test which uses the tool box facility. My additions to the tool box might not be the done in the most idiomatic style for that API; happy to have guidance on how to proceed better there.
> Assuming this general approach is agreed to, I'll update the imports on AutomaticModules.java to condense the text of the annotation processor source.

Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:

  Respond to review feedback.


  - all: https://git.openjdk.java.net/jdk/pull/3382/files
  - new: https://git.openjdk.java.net/jdk/pull/3382/files/5dab5c2f..cea0aa16

 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3382&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3382&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3382.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3382/head:pull/3382

PR: https://git.openjdk.java.net/jdk/pull/3382

More information about the compiler-dev mailing list