RFR: 8200145: Conditional expression mistakenly treated as standalone [v3]

Guoxiong Li github.com+13688759+lgxbslgx at openjdk.java.net
Sat Apr 17 15:16:13 UTC 2021


> Hi all,
> 
> If the argument `Type t` of the method `Types.unboxedType` is an `ErrorType`, the `Types.unboxedType` may return the wrong result. And in this case, `Attr.isBooleanOrNumeric` and `Attr.isBooleanOrNumeric` return the wrong result, too.
> 
> This patch fixes it and adds a test case.
> Thank you for taking the time to review.
> 
> Best Regards.
> -- xiong

Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 -  Merge branch 'master' into JDK-8200145
 - Use method isErroneous
 - 8200145: Conditional expression mistakenly treated as standalone

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2324/files
  - new: https://git.openjdk.java.net/jdk/pull/2324/files/2fe7665d..ec4c6402

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2324&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2324&range=01-02

  Stats: 238854 lines in 6772 files changed: 141667 ins; 67989 del; 29198 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2324.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2324/head:pull/2324

PR: https://git.openjdk.java.net/jdk/pull/2324


More information about the compiler-dev mailing list