compiler-dev Digest, Vol 168, Issue 19

[IvaN Cabral]

Ok

A sábado, 17/04/2021, 6:55 AM, <compiler-dev-request at openjdk.java.net>
escreveu:

> Send compiler-dev mailing list submissions to
>         compiler-dev at openjdk.java.net
>
> To subscribe or unsubscribe via the World Wide Web, visit
>         https://mail.openjdk.java.net/mailman/listinfo/compiler-dev
> or, via email, send a message with subject or body 'help' to
>         compiler-dev-request at openjdk.java.net
>
> You can reach the person managing the list at
>         compiler-dev-owner at openjdk.java.net
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of compiler-dev digest..."
>
>
> Today's Topics:
>
>    1. Re: RFR: 8200145: Conditional expression mistakenly treated
>       as standalone [v2] (Guoxiong Li)
>    2. Re: RFR: 8200145: Conditional expression mistakenly treated
>       as standalone [v2] (Guoxiong Li)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Sat, 17 Apr 2021 07:27:55 GMT
> From: Guoxiong Li <github.com+13688759+lgxbslgx at openjdk.java.net>
> To: <compiler-dev at openjdk.java.net>
> Subject: Re: RFR: 8200145: Conditional expression mistakenly treated
>         as standalone [v2]
> Message-ID:
>         <R8e_Xl3svxqUlJmZna3ddXZY9rgychL1iFyzyjc4YqE=.
> 05c29601-f01b-4cc7-a251-b6f80b7490d5 at github.com>
>
> Content-Type: text/plain; charset=utf-8
>
> > Hi all,
> >
> > If the argument `Type t` of the method `Types.unboxedType` is an
> `ErrorType`, the `Types.unboxedType` may return the wrong result. And in
> this case, `Attr.isBooleanOrNumeric` and `Attr.isBooleanOrNumeric` return
> the wrong result, too.
> >
> > This patch fixes it and adds a test case.
> > Thank you for taking the time to review.
> >
> > Best Regards.
> > -- xiong
>
> Guoxiong Li has updated the pull request incrementally with one additional
> commit since the last revision:
>
>   Use method isErroneous
>
> -------------
>
> Changes:
>   - all: https://git.openjdk.java.net/jdk/pull/2324/files
>   - new:
> https://git.openjdk.java.net/jdk/pull/2324/files/bf5e88f1..2fe7665d
>
> Webrevs:
>  - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2324&range=01
>  - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2324&range=00-01
>
>   Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
>   Patch: https://git.openjdk.java.net/jdk/pull/2324.diff
>   Fetch: git fetch https://git.openjdk.java.net/jdk
> pull/2324/head:pull/2324
>
> PR: https://git.openjdk.java.net/jdk/pull/2324
>
>
> ------------------------------
>
> Message: 2
> Date: Sat, 17 Apr 2021 07:27:57 GMT
> From: Guoxiong Li <github.com+13688759+lgxbslgx at openjdk.java.net>
> To: <compiler-dev at openjdk.java.net>
> Subject: Re: RFR: 8200145: Conditional expression mistakenly treated
>         as standalone [v2]
> Message-ID:
>         <9FjETXbXJpFjR_on0XyQqZaK3iwp0VrysQ99YrhXtFI=.
> 0582cdc9-767a-4388-aed3-db647ccf5405 at github.com>
>
> Content-Type: text/plain; charset=utf-8
>
> On Fri, 16 Apr 2021 15:54:05 GMT, Maurizio Cimadamore <
> mcimadamore at openjdk.org> wrote:
>
> >> Guoxiong Li has updated the pull request incrementally with one
> additional commit since the last revision:
> >>
> >>   Use method isErroneous
> >
> > src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java line
> 1959:
> >
> >> 1957:         //where
> >> 1958:             boolean primitiveOrBoxed(Type t) {
> >> 1959:                 return (!t.hasTag(TYPEVAR) && !t.hasTag(ERROR) &&
> types.unboxedTypeOrType(t).isPrimitive());
> >
> > Good catch - you can also use `!t.isErroneous()` here.
>
> Fixed.
>
> -------------
>
> PR: https://git.openjdk.java.net/jdk/pull/2324
>
>
> End of compiler-dev Digest, Vol 168, Issue 19
> *********************************************
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20210417/91984ca3/attachment.htm>