RFR: 8057543: Replace javac's Filter with Predicate (and lambdas)

Guoxiong Li github.com+13688759+lgxbslgx at openjdk.java.net
Mon Apr 19 00:22:41 UTC 2021


On Fri, 5 Mar 2021 21:59:46 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Hi all,
>> 
>> This patch replaces javac's `Filter` with `Predicate` and sets `Filter` as `Deprecated`.
>> Two existing tests failed and I fixed it.
>> Currently, all the tests in `test/langtools` passed locally by using the following command.
>> 
>> 
>> make test CONF=linux-x86_64-server-release JOBS=4 TEST=test/langtools/
>> 
>> 
>> Thank you for taking the time to review.
>> 
>> Best Regards.
>
> This looks very good - sorry I missed it. If you reopen I will approve!

@mcimadamore Who should we ping to solve the `reopen` problem? I have several PRs which were closed by the robot and need to be reopen too.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1898


More information about the compiler-dev mailing list