RFR: 8057543: Replace javac's Filter with Predicate (and lambdas)

[Maurizio Cimadamore]

On Sun, 27 Dec 2020 14:54:16 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> This patch replaces javac's `Filter` with `Predicate` and sets `Filter` as `Deprecated`.
> Two existing tests failed and I fixed it.
> Currently, all the tests in `test/langtools` passed locally by using the following command.
> 
> 
> make test CONF=linux-x86_64-server-release JOBS=4 TEST=test/langtools/
> 
> 
> Thank you for taking the time to review.
> 
> Best Regards.

Looks good - left some comments

src/jdk.compiler/share/classes/com/sun/tools/javac/api/JavacScope.java line 2:

> 1: /*
> 2:  * Copyright (c) 2006, 2020, Oracle and/or its affiliates. All rights reserved.

copyright in this (and other files need to be updated)

src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java line 94:

> 92:     final Symtab syms;
> 93:     final JavacMessages messages;
> 94:     private Names names;

where is this change coming from?

src/jdk.compiler/share/classes/com/sun/tools/javac/util/Filter.java line 36:

> 34:  * instead of {@link com.sun.tools.javac.util.Filter}.
> 35:  */
> 36: @Deprecated(forRemoval = true, since = "17")

This is not a public API - we're in a JDK internal class - if this class is no longer needed (as is the goal of this change) simply remove it :-)

-------------

PR: https://git.openjdk.java.net/jdk/pull/1898