RFR: 8057543: Replace javac's Filter with Predicate (and lambdas) [v2]

Maurizio Cimadamore mcimadamore at openjdk.java.net
Thu Apr 22 13:48:41 UTC 2021

On Wed, 21 Apr 2021 15:33:00 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> This patch replaces javac's `Filter` with `Predicate` and sets `Filter` as `Deprecated`.
>> Two existing tests failed and I fixed it.
>> Currently, all the tests in `test/langtools` passed locally by using the following command.
>> make test CONF=linux-x86_64-server-release JOBS=4 TEST=test/langtools/
>> Thank you for taking the time to review.
>> Best Regards.
> Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>  - Remove file Filter.java
>  - Update copyright
>  - Merge branch 'master' into JDK-8057543
>    # Conflicts:
>    #	src/jdk.compiler/share/classes/com/sun/tools/javac/parser/Tokens.java
>  - Add comments.
>  - 8057543: Replace javac's Filter with Predicate (and lambdas)

I agree that all these issues have been fixed - sorry - I thought these issues wanted to replace the various interfaces with interfaces from `j.u.function` (as done in this patch) - but these were about using lambda expressions more where possible - yeah I fixed that long ago.


PR: https://git.openjdk.java.net/jdk/pull/1898

More information about the compiler-dev mailing list