RFR: 8057543: Replace javac's Filter with Predicate (and lambdas) [v3]

Maurizio Cimadamore mcimadamore at openjdk.java.net
Thu Apr 22 16:09:23 UTC 2021


On Thu, 22 Apr 2021 16:04:51 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> This patch replaces javac's `Filter` with `Predicate` and sets `Filter` as `Deprecated`.
>> Two existing tests failed and I fixed it.
>> Currently, all the tests in `test/langtools` passed locally by using the following command.
>> 
>> 
>> make test CONF=linux-x86_64-server-release JOBS=4 TEST=test/langtools/
>> 
>> 
>> Thank you for taking the time to review.
>> 
>> Best Regards.
>
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert variabl names to modifier final

Looks good!

-------------

Marked as reviewed by mcimadamore (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1898


More information about the compiler-dev mailing list