RFR: 8239596: PARAMETER annotation on receiver type does not cause error [v2]

Vicente Romero vromero at openjdk.java.net
Fri Apr 23 19:23:38 UTC 2021


On Fri, 23 Apr 2021 11:15:11 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> `TypeAnnotationsValidator::visitMethodDef`  uses `checkForDeclarationAnnotations` incorrectly so that the check could not work as expected and some related errors are not reported. This patch fixes it and adds a corresponding test case.
>> 
>> Thank you for taking the time to review.
>> 
>> Best Regards.
>
> Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Use meaningful class name and update copyright
>  - Merge branch 'master' into JDK-8239596
>  - 8239596: PARAMETER annotation on receiver type does not cause error

looks sensible

-------------

Marked as reviewed by vromero (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1881


More information about the compiler-dev mailing list