RFR: 8231179: Investigate why tools/javac/options/BCPOrSystemNotSpecified.java fails on Window [v5]

[Vicente Romero]

On Mon, 19 Apr 2021 04:36:03 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> The statement `String sourcePath = file.getName();` in method `prepareBCP(Path target)` would use `DirectoryFileObject::getName` which is shown below.
>> 
>> 
>> @Override @DefinedBy(Api.COMPILER)
>> public String getName() {
>>     return relativePath.resolveAgainst(userPackageRootDir).toString();  // <-----------------
>> }
>> 
>> 
>> And the `DirectoryFileObject::getName` would use `RelativePath::resolveAgainst` which is shown below
>> 
>> 
>> public Path resolveAgainst(Path directory) throws /*unchecked*/ InvalidPathException {
>>     String sep = directory.getFileSystem().getSeparator();  // <---------------------
>>     return directory.resolve(path.replace("/", sep));
>> }
>> 
>> 
>> We can see that `RelativePath::resolveAgainst` use file system separator instead of operating system separator. In method `prepareBCP`, the file system should be JRT file system, but we don't need to know actually which file system to be used. We only need to use the same file system separator so that the test can run as expected.
>> 
>> This patch fixes the test by using the file system separator instead of operating system separator.
>> 
>> Thank you for taking the time to review.
>> 
>> Best Regards.
>
> Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
> 
>  - Merge branch 'master' into JDK-8231179
>    
>    # Conflicts:
>    #	test/langtools/ProblemList.txt
>  - Merge branch 'master' into JDK-8231179
>  - Merge branch 'master' into JDK-8231179
>  - Use StandardJavaFileManager::asPath
>  - Modify copyright
>  - 8231179: Investigate why tools/javac/options/BCPOrSystemNotSpecified.java fails on Window

looks good to me

-------------

Marked as reviewed by vromero (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2004