RFR: 8265900: Use pattern matching for instanceof at module jdk.compiler(part 2) [v2]

Guoxiong Li gli at openjdk.java.net
Mon Apr 26 14:44:50 UTC 2021


On Mon, 26 Apr 2021 13:52:50 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Refactor code style
>
> Looks good, one minor nit comment

@mcimadamore I updated the code. Could I get your help to re-review and sponsor? Thanks a lot.

> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Scope.java line 756:
> 
>> 754: 
>> 755:         protected Scope finalizeSingleScope(Scope impScope) {
>> 756:             if (impScope instanceof FilterImportScope filterImportScope && impScope.owner.kind == Kind.TYP &&
> 
> break vertically on each `&&` ?

Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3674


More information about the compiler-dev mailing list