RFR: 8225488: Examine ExecutableType.getReceiverType behavior when source receiver parameter is absent [v2]
Joe Darcy
darcy at openjdk.java.net
Mon Aug 9 18:10:12 UTC 2021
> A belated companion fix to JDK-8222369, this change updates ExecutableType.getReceiverType to have its specified behavior:
>
> Returns the return type of this executable. Returns a NoType with kind VOID if this executable is not a method, or is a method that does not return a value.
>
> rather than returning null, as the implementation did before. The ExecutableElement implementation in Symbol is updated accordingly to take advantage of the change in Type, along with augmenting the test from JDK-8222369 to cover the receiver type from the ExecutableType too.
>
> BasicAnnoTests.java is updated for revised offsets.
>
> All langtools tests pass with these changes and TestExecutableReceiverType.java fails with an unmodified javac in JDK 18.
>
> Please also review the companion CSR JDK-8271703, https://bugs.openjdk.java.net/browse/JDK-8271703
Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
- Merge and update copyrights.
- Merge branch 'master' into 8225488
- Appease jcheck.
- 8225488: Examine ExecutableType.getReceiverType behavior when source receiver parameter is absent
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/4965/files
- new: https://git.openjdk.java.net/jdk/pull/4965/files/ed3bed58..c9df1003
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4965&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4965&range=00-01
Stats: 11405 lines in 361 files changed: 9000 ins; 1427 del; 978 mod
Patch: https://git.openjdk.java.net/jdk/pull/4965.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/4965/head:pull/4965
PR: https://git.openjdk.java.net/jdk/pull/4965
More information about the compiler-dev
mailing list