RFR: 8266666: Implementation for snippets [v7]

[Pavel Rappo]

On Fri, 20 Aug 2021 18:25:02 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Pass through FIXMEs and TODOs
>>   
>>   Downgrades FIXMEs that do not mark *feature issues* to TODOs, or removes those FIXMEs completely. For example, unlike Style hierarchy, Action hierarchy won't benefit from becoming sealed. So the respective FIXME is removed.
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/snippet/Parser.java line 177:
> 
>> 175:                 }
>> 176:                 thisLineTags.addAll(parsedTags);
>> 177:                 for (var tagIterator = thisLineTags.iterator(); tagIterator.hasNext(); ) {
> 
> oooh, not wrong; just unexpected mix of styles ;-)

Can you be more specific? In what sense is this unexpected?

> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/snippet/Parser.java line 186:
> 
>> 184:                 }
>> 185:                 if (parsedTags.isEmpty()) { // (2)
>> 186:                     // TODO: log this with NOTICE;
> 
> does this need to be addressed?

I think that it does. It's the case of spurious markup. Such a case likely requires author's attention.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4795