RFR: 8266666: Implementation for snippets [v7]

Jonathan Gibbons jjg at openjdk.java.net
Mon Aug 23 17:39:36 UTC 2021


On Mon, 23 Aug 2021 16:01:51 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java line 923:
>> 
>>> 921:          * probably be considered on a case-by-case basis, for an attribute
>>> 922:          * value of the {@snippet} tag we do not recurse.
>>> 923:          */
>> 
>> This discussion does not belong here.
>> 
>> We should specify simple defensible rules (in the spec) and implement them accordingly.
>> If there is nothing more obvious, I suggest the rules for (Unicode) identifiers.
>
>> This discussion does not belong here.
> 
> I've hoped to specify tag syntax before we push this PR. Until the syntax has been specified, the comment has to be stored somewhere. What would be an appropriate place to store that comment in?
> 
>> I suggest the rules for (Unicode) identifiers
> 
> What do those rules look like? Do you have a link handy?

Check `Character.isUnicodeIdentifierStart` / `Character.isUnicodeIdentifierPart`
Variant suggestion (if different) ... use the identifier rules for the name of the attribute

-------------

PR: https://git.openjdk.java.net/jdk/pull/4795


More information about the compiler-dev mailing list