RFR: 8276766: Enable jar and jmod to produce deterministic timestamped content [v17]
Andrew Leonard
aleonard at openjdk.java.net
Mon Dec 6 12:08:50 UTC 2021
On Fri, 3 Dec 2021 10:05:43 GMT, Andrew Leonard <aleonard at openjdk.org> wrote:
>> Add a new --source-date <TIMESTAMP> (epoch seconds) option to jar and jmod to allow specification of time to use for created/updated jar/jmod entries. This then allows the ability to make the content deterministic.
>>
>> Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>
> Andrew Leonard has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 25 commits:
>
> - Merge jdk:master
>
> Signed-off-by: Andrew Leonard <anleonar at redhat.com>
> - Merge branch 'master' of https://github.com/openjdk/jdk into jarjmodtimestamps
> - 8276766: Enable jar and jmod to produce deterministic timestamped content
>
> Signed-off-by: Andrew Leonard <anleonar at redhat.com>
> - Merge branch 'jarjmodtimestamps' of github.com:andrew-m-leonard/jdk into jarjmodtimestamps
> - Update src/jdk.jlink/share/classes/jdk/tools/jmod/JmodOutputStream.java
>
> Co-authored-by: Magnus Ihse Bursie <mag at icus.se>
> - Merge branch 'master' of https://github.com/openjdk/jdk into jarjmodtimestamps
> - 8276766: Enable jar and jmod to produce deterministic timestamped content
>
> Signed-off-by: Andrew Leonard <anleonar at redhat.com>
> - 8276766: Enable jar and jmod to produce deterministic timestamped content
>
> Signed-off-by: Andrew Leonard <anleonar at redhat.com>
> - 8276766: Enable jar and jmod to produce deterministic timestamped content
>
> Signed-off-by: Andrew Leonard <anleonar at redhat.com>
> - 8276766: Enable jar and jmod to produce deterministic timestamped content
>
> Signed-off-by: Andrew Leonard <anleonar at redhat.com>
> - ... and 15 more: https://git.openjdk.java.net/jdk/compare/45da3aea...06863697
> I looked at the latest patch ([0686369](https://github.com/openjdk/jdk/commit/068636971e833cb582790667171a67e40c823bb1)) and I think you've got it to a good place (and thank you to John Neffenger for all the help).
>
> One comment on the usage message is that it might be a bit clearer to say "for the timestamps of entries" rather than "for entry timestamps". I'm also wondering if it would be useful to include an example of an ISO 8601 in the usage message.
@AlanBateman thanks. I've reworded, and added an example
-------------
PR: https://git.openjdk.java.net/jdk/pull/6481
More information about the compiler-dev
mailing list