RFR: 8276766: Enable jar and jmod to produce deterministic timestamped content [v20]

Andrew Leonard aleonard at openjdk.java.net
Thu Dec 9 18:08:03 UTC 2021


On Wed, 8 Dec 2021 16:51:05 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Andrew Leonard has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8276766: Enable jar and jmod to produce deterministic timestamped content
>>   
>>   Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>
> src/jdk.jartool/share/classes/sun/tools/jar/Main.java line 2339:
> 
>> 2337:         } else {
>> 2338:           e.setTime(origTime);
>> 2339:         }
> 
> I think the 8 usages would be a bit clearer if renamed setZipEntryTime. Minor nit in the 2-arg setDate is that it's using 2-space indent instead of 4.

thanks, fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/6481


More information about the compiler-dev mailing list