RFR: 8271079: JavaFileObject#toUri and multi-release jars [v3]

Christian Stein cstein at openjdk.java.net
Sat Dec 11 11:29:53 UTC 2021


On Fri, 10 Dec 2021 16:33:33 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Turn `getRealPath()` into a no-arg helper method
>
> test/langtools/tools/javac/T8271079.java line 58:
> 
>> 56:             testT8271079(mr);
>> 57:         } finally {
>> 58:             Files.deleteIfExists(mr);
> 
> If you generate files in the test's current directory, it's not wrong to delete them but there's no need either, and you might be deleting useful debug evidence if the test fails.

Understood.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6768


More information about the compiler-dev mailing list