RFR: 8241356: Use a more reliable way to encode Symbol flags [v2]

[Jonathan Gibbons]

On Fri, 12 Feb 2021 00:12:07 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removing merge tags are noted on the review - thanks!
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Extern.java line 594:
> 
>> 592:         } else {
>> 593:             ModuleSymbol msym = (ModuleSymbol) me;
>> 594:             return msym.isFlagSet(TypeSymbolFlags.AUTOMATIC_MODULE);
> 
> The change is OK, but the code being changed is not. There should not be references to any `javac.code.*` types outside of the `WorkArounds` class.  Ideally, this function (`isAutomaticModule`) should be on the `Elements` class.

FYI, PR 2537 will move this code to the `Workarounds` class.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2316