8260403: javap should be more robust in the face of invalid class files

Adam Sotona adam.sotona at oracle.com
Thu Feb 25 15:58:47 UTC 2021


Hi Vicente,
thanks for the review.

May I ask you also to /sponsor this PR?

Thanks again,
Adam


On 25/02/2021, 16:39, "core-libs-dev on behalf of Vicente Romero" <core-libs-dev-retn at openjdk.java.net on behalf of vromero at openjdk.java.net> wrote:

    On Thu, 25 Feb 2021 13:01:30 GMT, Adam Sotona <asotona at openjdk.org> wrote:

    > Please review javap fix to handle java.lang.IllegalStateException for classes with invalid Signature attribute.
    > New test (T8260403) parsing class with invalid Signature attribute (as described in the bug) is included.
    > Fix wraps java.lang.IllegalStateException, reports "Error: Invalid value for Signature attribute: <signature debug info>" and continues.
    > 
    > Thanks,
    > Adam

    lgtm!

    -------------

    Marked as reviewed by vromero (Reviewer).

    PR: https://git.openjdk.java.net/jdk/pull/2724



More information about the compiler-dev mailing list