Integrated: 8255729: com.sun.tools.javac.processing.JavacFiler.FilerOutputStream is inefficient
Guoxiong Li
github.com+13688759+lgxbslgx at openjdk.java.net
Sun Jan 3 17:35:57 UTC 2021
On Sun, 20 Dec 2020 17:29:59 GMT, Guoxiong Li <github.com+13688759+lgxbslgx at openjdk.org> wrote:
> Hi all,
>
> `FilerOutputStream` extends `FilterOutputStream` without overwriting the method `write(byte b[], int off, int len)` which would suffer from the performance problem.
> This patch fixes it and adds some `@Override` to polish the code. But I can't find a good way to write a corresponding test case. Maybe it doesn't need a test case. And all existing tests in `test/langtools/tools/javac` passed locally.
>
> Thank you for taking the time to review.
>
> Best Regards.
This pull request has now been integrated.
Changeset: 526c0005
Author: Guoxiong Li <lgxbslgx at gmail.com>
Committer: Jonathan Gibbons <jjg at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/526c0005
Stats: 9 lines in 1 file changed: 8 ins; 0 del; 1 mod
8255729: com.sun.tools.javac.processing.JavacFiler.FilerOutputStream is inefficient
Reviewed-by: jjg
-------------
PR: https://git.openjdk.java.net/jdk/pull/1854
More information about the compiler-dev
mailing list