RFR: 8241187: ToolBox::grep should allow for negative filtering [v2]

Guoxiong Li github.com+13688759+lgxbslgx at openjdk.java.net
Tue Jan 5 12:04:17 UTC 2021


> Hi all,
> 
> This patch adds two methods in `ToolBox` to do the negative filtering. Although the label `noreg-self` was added, I write a test for this enhancement to verify the code. And the method name `grepNotMatch` may need to be improved. Any idea is appreciated.
>  
> Thank you for taking the time to review.
> 
> Best Regards.

Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:

  Revise method and test.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1934/files
  - new: https://git.openjdk.java.net/jdk/pull/1934/files/26b1589d..f55e8a3a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1934&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1934&range=00-01

  Stats: 45 lines in 2 files changed: 27 ins; 2 del; 16 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1934.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1934/head:pull/1934

PR: https://git.openjdk.java.net/jdk/pull/1934


More information about the compiler-dev mailing list