RFR: 8150303: Rewrite test/tools/javac/Paths/Diagnostics.sh
Guoxiong Li
github.com+13688759+lgxbslgx at openjdk.java.net
Wed Jan 6 14:29:05 UTC 2021
Hi all,
This patch rewrites Diagnostics.sh to java code by using ToolBox API.
And I have a question: What does the `elts` mean in the following comments? Is it `elements`?
I think that a meaningful name should be used.
// Warn for missing elts in user-specified paths
// No warning for missing elts in "system" paths
Thank you for taking the time to review.
Best Regards.
-------------
Commit messages:
- 8150303: Rewrite test/tools/javac/Paths/Diagnostics.sh
Changes: https://git.openjdk.java.net/jdk/pull/1959/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1959&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8150303
Stats: 520 lines in 2 files changed: 310 ins; 210 del; 0 mod
Patch: https://git.openjdk.java.net/jdk/pull/1959.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/1959/head:pull/1959
PR: https://git.openjdk.java.net/jdk/pull/1959
More information about the compiler-dev
mailing list