[jdk16] RFR: 8258972: unexpected compilation error with generic sealed interface [v3]

Thu Jan 7 15:05:37 UTC 2021

On Tue, 5 Jan 2021 20:32:11 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Hi,
>> 
>> Please review this fix to the implementation of section `5.1.6.1 Allowed Narrowing Reference Conversion` of the Sealed Classes spec [1](http://cr.openjdk.java.net/~gbierman/jep397/jep397-20201204/specs/sealed-classes-jls.html#jls-5.1.6.1). IMO the compiler was not implementing the spec to the letter in particular the inheritance relation between a sealed class and a subclass should be tested ignoring type arguments which is what this patch is doing. Comments?
>> 
>> Thanks,
>> Vicente
>
> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
> 
>   adding missing calls to Types::erasure

Looks good to me.

-------------

Marked as reviewed by jlahoda (Reviewer).

PR: https://git.openjdk.java.net/jdk16/pull/72