[jdk16] RFR: JDK-8253996: Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing
Hannes Wallnöfer
hannesw at openjdk.java.net
Mon Jan 11 15:06:02 UTC 2021
On Wed, 23 Dec 2020 00:01:11 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
> This PR improves the diagnostic when javac is run in an image that does not provide a service provider for DocLint.
>
> Instead of reporting messages about unsupported options, the following warning will be generated:
>
> `
> Warning: No service provider for doclint is available
> `
>
> In addition, as a minor cleanup, in the `jdk.javadoc` module, javadoc b bypasses the service loader to access `doclint` directly.
Looks good!
test/langtools/tools/javac/doclint/LimitedImage.java line 58:
> 56: List<String> actualOutput;
> 57: List<String> expectedOutput = List.of(
> 58: "- compiler.warn.doclint.not.available",
Why is the warning key printed instead of the warning message? Limited image breaks property lookup?
test/langtools/tools/javac/doclint/LimitedImage.java line 62:
> 60: );
> 61:
> 62: //check proper diagnostics when zip/jar FS not present:
Should be "doclint" or "javadoc" instead of "zip/jar FS"
-------------
Marked as reviewed by hannesw (Reviewer).
PR: https://git.openjdk.java.net/jdk16/pull/60
More information about the compiler-dev
mailing list