RFR: 8260053: Optimize Tokens' use of Names [v2]

[Adam Sotona]

On Fri, 22 Jan 2021 08:23:50 GMT, Guoxiong Li <github.com+13688759+lgxbslgx at openjdk.org> wrote:

>> @lgxbslgx jmh-jdk-microbenchmarks contain a lot of various benchmarks and even micros-javac-... part can take hours if you run it all. As you mention you've successfully built jmh-jdk-microbenchmarks and so to execute only minimal necessary javac benchmarks in local environment you need to limit executed benchmarks to GroupJavacBenchmark only by command line: `java -jar micros-javac/target/micros-javac-1.0-SNAPSHOT.jar .+GroupJavacBenchmark.+` 
>> The argument given to JMH benchmarks is regular expression specifying what benchmarks to execute and by default it executes everything bundled.
>
>> As you mention you've successfully built jmh-jdk-microbenchmarks
> 
> I couldn't build successfully. Maybe my previous comments were not clear:
> 
>> When I built the code of this jmh-jdk-microbenchmarks project locally, I **could not get the result** over 5 hours which made me give up.
> 
>> I thought we shouldn't do the repetitive work so I used it but **failed to build it**. 
> 
> I understand that the test may take hours to run. But the build should not take so much time.
> @asotona Is it normal to take over 5 hours to build these code? I interrupted the build process when the time exceeded 5 hours.

@lgxbslgx OK, I see - it is definitely not normal to build it so long. Now I see from your log it got stuck at download of the reference jdk-bin.zip, which is used as benchmarks subject to compile. It indicates probably some networking obstacles, however the workaround is simple:

1. download the reference jdk-bin.zip from [https://download.java.net/openjdk/jdk11/ri/openjdk-11+28_windows-x64_bin.zip](https://download.java.net/openjdk/jdk11/ri/openjdk-11+28_windows-x64_bin.zip) manually
2. build benchmarks with property pointing to the local copy, for example: 
`mvn package -Djavac.benchmark.openjdk.zip.download.url=file:///<your download location>/openjdk-11+28_windows-x64_bin.zip`

-------------

PR: https://git.openjdk.java.net/jdk/pull/2169