RFR: 8260053: Optimize Tokens' use of Names [v2]

[Maurizio Cimadamore]

On Fri, 22 Jan 2021 14:32:16 GMT, Guoxiong Li <github.com+13688759+lgxbslgx at openjdk.org> wrote:

>> @asotona I built the test successfully. And the test is running. Thanks again.
>
> Hi all,
> 
> This is the result of the benchmark test.
> 
> The master branch:
> 
> Benchmark                                        Mode  Cnt   Score   Error  Units
> GroupJavacBenchmark.coldGroup                      ss   15  39.032 ± 2.142   s/op
> GroupJavacBenchmark.coldGroup:cold1_Init           ss   15   0.691 ± 0.119   s/op
> GroupJavacBenchmark.coldGroup:cold2_Parse          ss   15  11.259 ± 1.343   s/op
> GroupJavacBenchmark.coldGroup:cold3_InitModules    ss   15  11.735 ± 1.359   s/op
> GroupJavacBenchmark.coldGroup:cold4_Enter          ss   15  20.556 ± 2.403   s/op
> GroupJavacBenchmark.coldGroup:cold5_Attribute      ss   15  57.171 ± 3.202   s/op
> GroupJavacBenchmark.coldGroup:cold6_Flow           ss   15  59.490 ± 3.237   s/op
> GroupJavacBenchmark.coldGroup:cold7_Desugar        ss   15  69.980 ± 3.928   s/op
> GroupJavacBenchmark.coldGroup:cold8_Generate       ss   15  81.376 ± 4.422   s/op
> GroupJavacBenchmark.hotGroup                       ss   10  22.001 ± 1.084   s/op
> GroupJavacBenchmark.hotGroup:hot1_Init             ss   10   0.270 ± 0.042   s/op
> GroupJavacBenchmark.hotGroup:hot2_Parse            ss   10   6.812 ± 0.586   s/op
> GroupJavacBenchmark.hotGroup:hot3_InitModules      ss   10   7.025 ± 0.619   s/op
> GroupJavacBenchmark.hotGroup:hot4_Enter            ss   10  11.157 ± 0.904   s/op
> GroupJavacBenchmark.hotGroup:hot5_Attribute        ss   10  31.882 ± 1.465   s/op
> GroupJavacBenchmark.hotGroup:hot6_Flow             ss   10  32.996 ± 1.515   s/op
> GroupJavacBenchmark.hotGroup:hot7_Desugar          ss   10  40.072 ± 1.967   s/op
> GroupJavacBenchmark.hotGroup:hot8_Generate         ss   10  45.798 ± 2.170   s/op
> 
> The JDK-8260053 branch(this patch):
> 
> Benchmark                                        Mode  Cnt   Score    Error  Units
> GroupJavacBenchmark.coldGroup                      ss   15  39.878 ±  4.123   s/op
> GroupJavacBenchmark.coldGroup:cold1_Init           ss   15   0.696 ±  0.138   s/op
> GroupJavacBenchmark.coldGroup:cold2_Parse          ss   15  11.317 ±  1.422   s/op
> GroupJavacBenchmark.coldGroup:cold3_InitModules    ss   15  11.788 ±  1.428   s/op
> GroupJavacBenchmark.coldGroup:cold4_Enter          ss   15  20.339 ±  1.662   s/op
> GroupJavacBenchmark.coldGroup:cold5_Attribute      ss   15  58.910 ±  6.163   s/op
> GroupJavacBenchmark.coldGroup:cold6_Flow           ss   15  61.114 ±  6.619   s/op
> GroupJavacBenchmark.coldGroup:cold7_Desugar        ss   15  71.692 ±  9.120   s/op
> GroupJavacBenchmark.coldGroup:cold8_Generate       ss   15  83.169 ± 11.241   s/op
> GroupJavacBenchmark.hotGroup                       ss   10  22.024 ±  1.883   s/op
> GroupJavacBenchmark.hotGroup:hot1_Init             ss   10   0.273 ±  0.090   s/op
> GroupJavacBenchmark.hotGroup:hot2_Parse            ss   10   6.520 ±  0.576   s/op
> GroupJavacBenchmark.hotGroup:hot3_InitModules      ss   10   6.710 ±  0.581   s/op
> GroupJavacBenchmark.hotGroup:hot4_Enter            ss   10  10.756 ±  0.698   s/op
> GroupJavacBenchmark.hotGroup:hot5_Attribute        ss   10  32.317 ±  3.305   s/op
> GroupJavacBenchmark.hotGroup:hot6_Flow             ss   10  33.495 ±  3.486   s/op
> GroupJavacBenchmark.hotGroup:hot7_Desugar          ss   10  40.116 ±  3.698   s/op
> GroupJavacBenchmark.hotGroup:hot8_Generate         ss   10  46.002 ±  3.795   s/op
> 
> At `coldGroup:cold2_Parse`, this patch(11.317) is little higher than the master branch(11.259).
> At `hotGroup:hot2_Parse`, this patch(6.520) is little lower than the master branch(6.812).
> If my understanding of the data is correct, I believe this patch has little influence to performance.
> 
> The concrete log is attached below.
> [master.log](https://github.com/openjdk/jdk/files/5856433/master.log)
> [JDK-8260053.log](https://github.com/openjdk/jdk/files/5856434/JDK-8260053.log)

Yeah - I don't think there's any evidence in the benchmark run of a change in performances. I think this looks good -very nice work!

-------------

PR: https://git.openjdk.java.net/jdk/pull/2169