RFR: 8260566: Pattern type X is a subtype of expression type Y message is incorrect [v2]

Jan Lahoda jlahoda at openjdk.java.net
Fri Jan 29 13:22:43 UTC 2021


On Fri, 29 Jan 2021 12:49:06 GMT, Guoxiong Li <github.com+13688759+lgxbslgx at openjdk.org> wrote:

>> Hi all,
>> 
>> The order of the arguments is wrong when using method `Errors.InstanceofPatternNoSubtype`.
>> 
>> This patch fixes it and revises the corresponding tests.
>> Thank you for taking the time to review.
>> And it may be good to fix JDK16 as well.
>> 
>> Best Regards.
>> -- xiong
>
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revise error message.

Looks good to me.

Thanks for Tagir for pointing out the mistake in the error message.

-------------

Marked as reviewed by jlahoda (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2311


More information about the compiler-dev mailing list