Integrated: JDK-8268420: new Reporter method to report a diagnostic within a DocTree node
Jonathan Gibbons
jjg at openjdk.java.net
Fri Jul 9 16:19:01 UTC 2021
On Mon, 14 Jun 2021 21:45:11 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
> Please review an update to add a new method in Reporter to report a diagnostic within a DocTree node for those DocTree nodes that wrap a string.
>
> This is the last of the current round of updates to improve the diagnostics that can be generated by javadoc.
>
> The general fix, in JavadocLog and Reporter, is pretty simple, given all the improvements in recent related changes.
>
> There are some cosmetic cleanups that were made while exploring the current solution.
>
> The test is "reasonably thorough" and uses a custom taglet to generate diagnostics for selected nodes in doc comment trees. The test then "algorithmically validates" (i.e. no golden files or text blocks) the diagnostics that are either passed to a DiagnosticListener or written to the console stream.
This pull request has now been integrated.
Changeset: 3588634d
Author: Jonathan Gibbons <jjg at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/3588634d5403a6472fc88eb2ad8576f55cad2f89
Stats: 586 lines in 9 files changed: 569 ins; 5 del; 12 mod
8268420: new Reporter method to report a diagnostic within a DocTree node
Reviewed-by: prappo
-------------
PR: https://git.openjdk.java.net/jdk/pull/4489
More information about the compiler-dev
mailing list