Withdrawn: 8267355: Adjust the parameters of the method UnicodeReader#digit
duke
duke at openjdk.java.net
Wed Jul 14 07:57:18 UTC 2021
On Wed, 19 May 2021 06:39:23 GMT, Guoxiong Li <gli at openjdk.org> wrote:
> Hi all,
>
> This patch removes the parameter `int pos` of the method `UnicodeReader#digit`. Several places which use the method `UnicodeReader#digit` are adjusted, too.
>
> Thank you for taking the time to review.
>
> ---
>
> A related issue for comments.
>
> After merging this patch, the methods `JavaTokenizer#scanLitChar` and `JavaTokenizer#scanDigits` also have the unused parameters `int pos`. It seems that they could be removed, too.
> But I consider that the methods `scan***` of the class `JavaTokenizer` have a context which may look ahead or back. So their parameters `int pos` may be used in the future. Maybe it is good to remain them.
>
> What's your opionion? Any idea is appreciated.
>
> ---
>
> Best Regards,
> -- Guoxiong
This pull request has been closed without being integrated.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4106
More information about the compiler-dev
mailing list