Integrated: 8269656: The test test/langtools/tools/javac/versions/Versions.java has duplicate test cycles
Thejasvi Voniadka
tvoniadka at openjdk.java.net
Thu Jul 15 04:56:16 UTC 2021
On Wed, 30 Jun 2021 12:04:07 GMT, Thejasvi Voniadka <tvoniadka at openjdk.org> wrote:
> The test "test test/langtools/tools/javac/versions/Versions.java" duplicates some operations, while missing some others.
>
> From the execution log:
>
> ...
> test: check_source_target 52.0 8 8
> ...
> test: check_source_target 52.0 8 8
> ...
> test: check_source_target 53.0 9 9
> ...
> test: check_source_target 53.0 9 9
> ...
>
> We can notice the duplicates. Also some combinations are missed out. For example, "check -source 7 -target 8" is an expected combination in the output, but it is missed.
>
> I have updated the index boundaries of the inner for-loop to address this discrepancy.
>
> In addition, the test code contains an unreachable block of code, that causes the combination "most recent target" without a "-source" specifier to be missed out. I have updated the corresponding "if" condition too.
>
> I have verified that the test passes on all platforms.
This pull request has now been integrated.
Changeset: 04b73bc4
Author: Thejasvi Voniadka <tvoniadka at openjdk.org>
Committer: Abdul Kolarkunnu <akolarkunnu at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/04b73bc4e022740122463ef70791ef276ac9b34d
Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
8269656: The test test/langtools/tools/javac/versions/Versions.java has duplicate test cycles
Reviewed-by: darcy
-------------
PR: https://git.openjdk.java.net/jdk/pull/4639
More information about the compiler-dev
mailing list