RFR: 8266666: Implementation for snippets [v3]

[Pavel Rappo]

On Mon, 26 Jul 2021 17:05:45 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

>> Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve comments
>>   
>>   This commit adds trivial commentary to some of the Java declarations. This commit also adds the "This is NOT part of any supported API..." disclaimer.
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/snippet/parser/Parser.java line 275:
> 
>> 273:                         throw new ParseException("Unexpected attributes", t.lineSourceOffset + t.markupLineOffset + t.nameLineOffset);
>> 274:                     }
>> 275:                     actions.add(new Bookmark(region.value(), text.subText(t.start(), t.end() - 1)));
> 
> This method is a bit hard on the eyes and runs quite wide. Maybe add a few more line breaks on those very long lines?

So just to be clear, Hannes. Do you suggest to structure the rules like this?


pre.snippet {
    background-color: #e8e8e8;
    padding: 10px;
    margin: 12px 0;
    overflow: auto;
    white-space: pre;
}

pre.snippet .italic {
    font-style: italic;
}

pre.snippet .bold {
    font-weight: bold;
}

pre.snippet .highlighted {
    background-color: sandybrown;
    border-radius: 10%;
}

-------------

PR: https://git.openjdk.java.net/jdk/pull/4795