RFR: 8263642: javac emits duplicate checkcast for first bound of intersection type in cast [v2]
Guoxiong Li
gli at openjdk.java.net
Wed Jun 2 16:38:04 UTC 2021
On Wed, 2 Jun 2021 16:12:40 GMT, Vicente Romero <vromero at openjdk.org> wrote:
>> Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>>
>> - Remove the duplicated typecast nodes in the AST instead of ignoring it
>> - Check the type of the checkcast
>> - Merge branch 'master' into JDK-8263642
>> - 8263642: javac emits duplicate checkcast for first bound of intersection type in cast
>
> test/langtools/tools/javac/cast/intersection/DuplicatedCheckcastTest.java line 94:
>
>> 92: "Expected number: 2, actual number: " + checkCastList.size());
>> 93: }
>> 94: // first checkcast
>
> hi, there is common code in the two sections of code that check for the checkcast I suggest creating a method for the common code
Fixed.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3399
More information about the compiler-dev
mailing list