RFR: 8267832: SimpleVisitors and Scanners in jdk.compiler should use @implSpec [v2]

openjdk-notifier [bot] "github.com+73116608+openjdk-notifier[bot]" at openjdk.java.net
Mon Jun 7 07:06:01 UTC 2021


On Fri, 28 May 2021 19:07:17 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> As noted in:
>> https://bugs.openjdk.java.net/browse/JDK-8265981?focusedCommentId=14423316&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14423316
>> 
>> Methods in various utility visitor classes in jdk.compiler should use @implSpec to specify the implementation behavior. This patch tries to add the @implSpec tag to methods which already contain a text specifying the implementation, and adds new javadoc to the handful of methods that are missing it so far.
>> 
>> The CSR is started for review here:
>> https://bugs.openjdk.java.net/browse/JDK-8267838
>
> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reordering @implSpec and example as suggested.

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:


git checkout JDK-8262891
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

-------------

PR: https://git.openjdk.java.net/jdk/pull/4223


More information about the compiler-dev mailing list